Output .js files from wasm modules as ES6 modules. #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Jul 1, 2024
build/config/compiler/BUILD.gn
Outdated
Comment on lines
297
to
299
| "-s", | ||
| "MODULARIZE=1", | ||
| "-sEXPORT_ES6", |
There was a problem hiding this comment.
Why not
"-s",
"EXPORT_ES6",
Like the other options? (is it because it doesn't have =?)
There was a problem hiding this comment.
I think I just made an arbitrary choice. I can make it consistent with the others.
eyebrowsoffire
added
the
autosubmit
eyebrowsoffire
added a commit
that referenced
this pull request
Jul 1, 2024
This reverts commit 6c01dbc.
eyebrowsoffire
added a commit
that referenced
this pull request
Jul 2, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
) To go with the reland of ES6 modules stuff here: flutter/engine#53688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildroot changes needed for flutter/engine#52023