Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download.py #107

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Update download.py #107

merged 1 commit into from
Dec 4, 2020

Conversation

smudgeren
Copy link
Contributor

update open('README.md',encoding='utf8) to debug UnicodeDecodeError

@StephenLeeUSTC
Copy link

Vote for this fix. Have to be so on windows platform.

ghost
ghost suggested changes Mar 22, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with open('README.md', encoding='utf-8')

@RaicLee
Copy link

RaicLee commented May 22, 2019

i would suggest with open('README.md','rt',encoding='UTF8')

@floodsung floodsung merged commit 2dcb20c into floodsung:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smudgeren @StephenLeeUSTC @RaicLee @floodsung