Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3928] CLI rewrite #4023

Draft
wants to merge 34 commits into
base: dev
Choose a base branch
from
Draft

[FL-3928] CLI rewrite #4023

wants to merge 34 commits into from

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Nov 29, 2024 •
edited
Loading

What's new

  • Rewrote the CLI subsystem, which resulted in:
    • A nicer architecture
    • Reduced idle stack usage (4 KiB -> 0.75 KiB); reduced stack usage with a shell and a command running (4 KiB -> 3.75 KiB)
    • Better UX thanks to a real history and ANSI escape support in both directions (text formatting and keyboard shortcuts)
    • Semmingly better stability in companion apps even while using ANSI codes

Verification

  • Test the CLI shell
  • Test all the CLI commands
  • Test all the tools that depend on the CLI (companion apps, fbt, production line tooling, etc.)

Remarks

This PR depends on #3996, please review it before reviewing this one.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3
feat: FuriThread stdin
bf7fefc
@portasynthinca3
Merge branch 'dev' into portasynthinca3/3927-thread-stdin
a9d3264
@portasynthinca3
ci: fix f18
4c59243
@portasynthinca3
Merge branch 'dev' into portasynthinca3/3927-thread-stdin
9f2e934
@portasynthinca3
feat: stdio callback context
f1eb60b
@portasynthinca3
Merge branch 'dev' into portasynthinca3/3927-thread-stdin
da187fe
@portasynthinca3
feat: FuriPipe
a4a7a41
@portasynthinca3
POTENTIALLY EXPLOSIVE pipe welding
004e3a6
@portasynthinca3
fix: non-explosive welding
920a3e9
@portasynthinca3
Revert welding
f792fde
@portasynthinca3
docs: furi_pipe
1c9dbb3
@portasynthinca3
feat: pipe event loop integration
bd28387
@portasynthinca3
update f18 sdk
acf307d
@portasynthinca3
f18
2bcc3c4
@portasynthinca3
docs: make doxygen happy
af7ff81
@portasynthinca3
fix: event loop not triggering when pipe attached to stdio
857ad33
@portasynthinca3
fix: partial stdout in pipe
bc9223a
@portasynthinca3
allow simultaneous in and out subscription in event loop
dac9c00
@portasynthinca3
feat: vcp i/o
8837c8b
@portasynthinca3
feat: cli ansi stuffs and history
20ce18f
@portasynthinca3
feat: more line editing
1b31e70
@portasynthinca3
working but slow cli rewrite
82169a7
@portasynthinca3
restore previous speed after 4 days of debugging 🥲
fa1919c
@portasynthinca3
fix: cli_app_should_stop
bd82671
@portasynthinca3
fix: cli and event_loop memory leaks
34c6566
@portasynthinca3
style: remove commented out code
a346d8c
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

PVS-Studio report for commit b0b73c0e:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Compiled f7 firmware for commit 7a69500d:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes will be requested when the pull request is marked ready for review skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 will be requested when the pull request is marked ready for review DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger will be requested when the pull request is marked ready for review hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov will be requested when the pull request is marked ready for review gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov will be requested when the pull request is marked ready for review nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich will be requested when the pull request is marked ready for review gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra will be requested when the pull request is marked ready for review Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm will be requested when the pull request is marked ready for review Skorpionm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portasynthinca3 @gsurkov