Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model clock-domain crossings between transformed-RTL model and endpoints #49

Merged
merged 16 commits into from
Oct 12, 2018
Merged

Model clock-domain crossings between transformed-RTL model and endpoints #49

merged 16 commits into from
Oct 12, 2018

Conversation

davidbiancolin
Copy link
Contributor

@davidbiancolin davidbiancolin commented Jul 19, 2018 •
edited
Loading

Associated midas PR: ucb-bar/midas#90. See that PR for more detail.

As for FireSim specific stuff:

  • Adds Platform Configs for building simulators with clock divison between RC and DRAM models
  • Add recipes to run midas synthesizable unittests
  • Adds unittests to scala tests
    Some unrelated changes that could be dropped:
  • Adds an submodule init only mode to build setup.
    • this is a little hack for speeding up setup on millennium. I continue to have problems with the fast install toolchain working -- i need to full install (Should probably open an issue).

Ultimately we probably want to model 1:3 or 1:2 division between Rocket Chip and the DRAM model by default but i'm seeing some weird behavior in the QC-FRFCFS instances that must be addressed before that can even be considered.

@davidbiancolin davidbiancolin changed the title [WIP] Model clock-domain crossings between transformed-RTL model and endpoints Model clock-domain crossings between transformed-RTL model and endpoints Sep 28, 2018
@davidbiancolin
Copy link
Contributor Author

@zhemao @sagark this is ready for review

@sagark
Copy link
Member

sagark commented Oct 4, 2018

Re: fast-install toolchain, I don't think we expect it to work on millennium. We'd have to have a separate package for that.

sagark
sagark approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@sagark sagark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidbiancolin davidbiancolin merged commit 41a80ce into dev Oct 12, 2018
@sagark sagark mentioned this pull request Oct 12, 2018
Merged
3 tasks
@davidbiancolin davidbiancolin deleted the multiclock branch July 17, 2019 21:26
@KyleParker-Gongyuan KyleParker-Gongyuan mentioned this pull request Aug 22, 2022
Open
3 tasks
nandor pushed a commit that referenced this pull request Oct 18, 2022
@t14916
Merge pull request #49 from sifive/further_cron_job_adjustments
907041b 
Cron trigger improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagark sagark sagark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidbiancolin @sagark