Fix conda lockfile docs / make lockfile generation easier #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
requested changes
Mar 22, 2023
scripts/generate-conda-lockfile.sh
Outdated
| @@ -0,0 1,8 @@ | |||
| #!/bin/sh | |||
|
|
|||
| REQS_DIR="$(pwd)/conda-reqs" | |||
There was a problem hiding this comment.
This should be more robust so that it can be called in multiple places. I would use the following: https://stackoverflow.com/questions/59895/how-do-i-get-the-directory-where-a-bash-script-is-located-from-within-the-script. Then you can change the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a callable script that is also used by build-setup.sh to generate the conda lockfile, which makes it easier to make changes to dependencies / move dependencies between ci-shared and general.
Related PRs / Issues
UI / API Impact
Only UI change is instead of manually running conda-lock, there is now a script that generates the lockfile.
Verilog / AGFI Compatibility
Contributor Checklist
changelog:<topic>label?ci:fpga-deploylabel?Please Backportlabel?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy mainand manage the change from the new PR.changelog:<topic>label?