pickup fab-classic#77 by bumping to 1.19.2 #1443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fab-classic has logic to react to paramiko
SSHException
raised when server load is too high. In this case, fab-classic should retry the connection until it gets toenv.connection_attempts
(seefiresim/deploy/firesim
Line 437 in 0755382
NetworkError
.The logic in fab-classic 1.19.1 does not correctly match the paramiko exception message in all the required cases and incorrectly stops retrying the connection before reaching
env.connection_attempts
(it falls down a path where it aborts because the code thinks it should be querying the user for a password).This fix makes the firesim manager more robust in environments where the server networking performance is struggling to keep up.
We may further want to catch
NetworkError
when in therunworkload
monitoring loop so that hosts could be marked???
for as long as we're unable to connect to them, rather than causing the monitoring loop to die so that the user is responsible for manually monitoring their workload and collecting results. I leave that for a future PR.Related PRs / Issues
fab-classic#77 fixing fab-classic#76
UI / API Impact
No impact
Verilog / AGFI Compatibility
No impact.
Contributor Checklist
changelog:<topic>
label?ci:fpga-deploy
label?Please Backport
label?Reviewer Checklist (only modified by reviewer)
Note: to run CI on PRs from forks, comment
@Mergifyio copy main
and manage the change from the new PR.changelog:<topic>
label?