Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vitis driver CI check #1415

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Fix Vitis driver CI check #1415

merged 2 commits into from
Jan 28, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Jan 27, 2023

#1414 was merged a bit too early with auto-merge. The bug was that using the cd() fabric function instead of prefix() results in the cd() function being called before the prefix() function thus causing the cd to fail. This changes it to just use prefix'es instead. Additionally, you need to change the PLATFORM make flag for there to be a vitis target or else it will error.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez self-assigned this Jan 27, 2023
@abejgonzalez abejgonzalez changed the title Fix order of cd in Vitis driver CI Fix Vitis driver CI check Jan 28, 2023
Copy link
Contributor

@nandor nandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved & merged since this showed up in other PRs.

@nandor nandor merged commit a96ce04 into main Jan 28, 2023
@nandor nandor deleted the fix-vitis-driver-ci branch January 28, 2023 12:43
nandor pushed a commit that referenced this pull request Feb 1, 2023
* Fix order of cd in Vitis driver CI

* Add PLATFORM flag to driver build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants