Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incremental builds triggered by scala changes #1408

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix incremental builds triggered by scala changes #1408

merged 1 commit into from
Jan 26, 2023

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Jan 26, 2023

Fixed the DRY'd grep pattern. Incremental builds should work now.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@nandor nandor added the changelog:fixed Put PR title in 'Fixed' section of changelog label Jan 26, 2023
@nandor
Fix incremental builds triggered by scala changes
7389633 
Fixed the DRY'd grep pattern. Incremental builds should work now.
@nandor nandor enabled auto-merge (squash) January 26, 2023 15:49
fabianschuiki
fabianschuiki approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nandor nandor merged commit 6d39766 into main Jan 26, 2023
@nandor nandor deleted the build-fix branch January 26, 2023 17:56
@sifive-benjamin-morse
Copy link
Contributor

awesome! thanks it works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@sifive-benjamin-morse sifive-benjamin-morse Awaiting requested review from sifive-benjamin-morse

Assignees
No one assigned
Labels
changelog:fixed Put PR title in 'Fixed' section of changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandor @sifive-benjamin-morse @fabianschuiki