Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow not to set logger #3

Merged
merged 1 commit into from
Jan 26, 2023
Merged

feat: allow not to set logger #3

merged 1 commit into from
Jan 26, 2023

Conversation

wikylyu
Copy link
Contributor

@wikylyu wikylyu commented Jan 26, 2023

Use NilLogger as default Logger, which will not log any thing.

@firefart
Copy link
Owner

thanks! Can you please revert the module name change so I can merge it into main:?

@wikylyu
Copy link
Contributor Author

wikylyu commented Jan 26, 2023

reverted. sorry for the mistake. It's used for my local testing.

@firefart firefart merged commit c468788 into firefart:main Jan 26, 2023
@firefart
Copy link
Owner

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wikylyu @firefart