fix: only pass TSC deadline feature if the host supports it #4655
8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
the
Status: Awaiting author
pb8o
force-pushed
the
gh-4099
branch
2 times, most recently
from
728c92b
to
f061302
Compare
In commit f5906ee we moved the initialization of the list but forgot to change it here. Fixes: f5906ee Signed-off-by: Pablo Barbáchano <[email protected]>
AMD hosts do not have TSC deadline enabled, and that seems to cause issues like in firecracker-microvm#4099. Only expose TSC_DEADLINE to the guest if the host supports it. Closes firecracker-microvm#4099 Signed-off-by: Pablo Barbáchano <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4655 /- ##
=======================================
Coverage 82.08% 82.08%
=======================================
Files 255 255
Lines 31257 31264 7
=======================================
Hits 25656 25663 7
Misses 5601 5601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
reviewed
Jun 26, 2024
| @@ -247,7 247,14 @@ impl super::Cpuid { | |||
| // operation using a TSC deadline value. | |||
| // | |||
| // tsc_deadline: 24, | |||
| set_bit(&mut leaf_1.result.ecx, ECX_TSC_DEADLINE_BITINDEX, true); | |||
| let host_leaf_1 = cpuid(0x1); | |||
There was a problem hiding this comment.
Lest we forget: in case this makes it off the draft, we'll need to update the doc: https://github.com/firecracker-microvm/firecracker/blob/main/docs/cpu_templates/cpuid-normalization.md
pb8o
commented
Jun 27, 2024
| set_bit( | ||
| &mut leaf_1.result.ecx, | ||
| ECX_TSC_DEADLINE_BITINDEX, | ||
| host_tsc_deadline, |
There was a problem hiding this comment.
This causes a 40-50% regression in boot time. Currently investigating.
|
Superseded by #4666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.