Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't spam console with "failed to write to tap" messages #4650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't spam console with "failed to write to tap" messages #4650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't spam console with "failed to write to tap" messages 
A common first experience with firecracker (see e.g. #746) is to start a
new virtual machine and immediately start getting spammed with messages
like:

    2024-06-21T22:10:18.189726925 [anonymous-instance:main] Failed to write
    to tap: Os { code: 5, kind: Uncategorized, message: "Input/output
    error" }

This happens because firecracker will create the tap device if it doesn't
already exist, and unlike most vmms it will not configure the device `up`
in this case.

All that means that this is both a common and an expected situation and
does not require this level of notification.

Signed-off-by: Lars Kellogg-Stedman <[email protected]>
  • Loading branch information
@larsks
larsks committed Jun 22, 2024
commit c5c5db1b9e707ee8d5cb541e03947966da110b1a
3 changes: 1 addition & 2 deletions src/vmm/src/devices/virtio/net/device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 498,7 @@ impl Net {
net_metrics.tx_packets_count.inc();
net_metrics.tx_count.inc();
}
Err(err) => {
error!("Failed to write to tap: {:?}", err);
Err(_) => {
net_metrics.tap_write_fails.inc();
}
};
Expand Down