Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startActivityForResult depricated #316

Open
shrirampanchal opened this issue Oct 9, 2021 · 4 comments
Open

startActivityForResult depricated #316

shrirampanchal opened this issue Oct 9, 2021 · 4 comments
Assignees
@thatfiredev
Labels
help wanted

Comments

@shrirampanchal
Copy link

shrirampanchal commented Oct 9, 2021 •
edited
Loading

Since startActivityForResult depricated how to target GoogleSignIn for new android versions
@MatthewFallon
Copy link

May get around to this later, but wanted to post the relevant links that show up for fixing this and the areas I found the problem in.

snippets-android/auth/app/src/main/java/com/google/firebase/quickstart/auth/GoogleSignInActivity.java

Line 128 in 7268f81

startActivityForResult(signInIntent, RC_SIGN_IN);

snippets-android/auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/GoogleSignInActivity.kt

Line 100 in 7268f81

startActivityForResult(signInIntent, RC_SIGN_IN)

Links:
https://developer.android.com/training/basics/intents/result
https://stackoverflow.com/questions/62671106/onactivityresult-method-is-deprecated-what-is-the-alternative

@thatfiredev
Copy link
Member

@MatthewFallon Let me know if you still wish to contribute :)

@thatfiredev thatfiredev self-assigned this Apr 21, 2022
@yveskalume
Copy link

Hey @thatfiredev is it to late to contribute ?

@thatfiredev
Copy link
Member

@yveskalume I'm looking at our docs for Google Sign-in, and it seems like they have been updated for One Tap Sign-in and we no longer use startActivityForResult, so this should no longer be an issue. 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatfiredev thatfiredev

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shrirampanchal @marinacoelho @MatthewFallon @thatfiredev @yveskalume