Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed structure and file names for index.js, package.json, package-lock.json #1346

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Changed structure and file names for index.js, package.json, package-lock.json #1346

merged 1 commit into from
Aug 9, 2023

Conversation

paulinon
Copy link
Contributor

@paulinon paulinon commented Aug 8, 2023

Following the instructions in quickstart-unity/functions/testapp/readme.md led to an error message noted by the developer in qs1345. Created this PR to resolve this issue.

AlmostMatt
AlmostMatt approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like all of the old names lost the slash at some point.

@AlmostMatt AlmostMatt merged commit 20ccf6e into firebase:master Aug 9, 2023
1 check passed
@AlmostMatt AlmostMatt mentioned this pull request Aug 9, 2023
Merged
3 tasks
@firebase firebase locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulinon @AlmostMatt