Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Ability to remove custom key #1168

Open
ByMedion opened this issue Oct 31, 2021 · 4 comments
Open

[FR] Ability to remove custom key #1168

ByMedion opened this issue Oct 31, 2021 · 4 comments

Comments

@ByMedion
Copy link

Hi! It would be cool if it was possible to delete a custom key when it is no longer needed.

Example: when entering the game screen, I create a custom key "level_config", in which I specify some data (level id and etc.). After exiting the game screen, I no longer need to see this key in the list in the next possible error (of course, if it happened not on the game screen).

Now I can clear the key value, but it will still remain in the list. If there are many such keys depending on some condition, then the list will turn into a mess!

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@ByMedion
Copy link
Author

ByMedion commented Nov 3, 2021

@paulinon Hello! I apologize, I forgot to clarify that this question is about crashlytics, not for analytics. I think the label should be "api: crashlytics"

@samedson
Copy link

Hey @ByMedion - you may be able to do this by passing a null to the SetCustomKey method. Let me know what you experience (and whether this is different on Android vs iOS).

@FrantisekHolubec
Copy link

FrantisekHolubec commented Apr 24, 2024

In SetCustomKey there is null check for value, and throws exception, otherwise people suggested that it actually might work. could you remove this null check ?

 public override void SetCustomKey(string key, string value)
    {
      if (key == null || value == null)
        throw new ArgumentNullException("key and value should not be null");
      this.CallInternalMethod((System.Action) (() => this.crashlyticsInternal.SetCustomKey(key, value)), nameof (SetCustomKey));
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants