-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Remote Config FetchAsync throws exception with TimeSpan #1138
Comments
Hi @Nyankoo, Thanks for reporting this issue. Version 8.2.0 of the SDK has been released recently. Could you verify if the issue persists there as well? If it does, please provide a minimal, reproducible example of your project along with the complete steps to replicate this behavior. |
@paulinon Did something in Version 8.2.0 change related to Remote Config? The changelog doesn't mention anything. |
Hi @Nyankoo, While the release notes don't mention anything related to Remote Config, this is to ensure that the issue persists even with the latest updates and fixes. I look forward to your findings. |
I can confirm we are seeing this issue, on 8.2.0. It's causing our app to fully hang. We are sending in a timespan of 1 minute. We started seeing this about 4 weeks ago. Can confirm removing the timespan argument stopped the issue from happening, but we can't wait for ~12 hours for remote config updates! Should be simple enough to reproduce in an empty project on your end. |
@paulinon We didn't had a change to update, but Dan's report shows that this is also happening with 8.2.0. |
Also note @paulinon in our tests, this happened about 2/10 times-ish. |
If we remove the cache expiry, it works 100% of the time. |
Thanks for the input, @Nyankoo and @DanForstinger. So far, I have not encountered the exception when using the FetchAsync() function. A minimal, reproducible example would be helpful in identifying what's causing the exception. Could you also confirm if the same exception persists using the quickstart? |
A few notes that may help you reproduce:
|
For us, the app just hangs and never calls back from the async function, though we may not have got the errors because the initialization wasn't finishing on the main thread. |
To clarify, the situation Dan is describing is only happening after building on certain machines (CI vs local build), and only shows up at all for some % of users (some people don't see it at all.) It also started appearing randomly for an existing game we'd launched and made no changes to — which actually seems to suggest this is something happening on the firebase server side, rather than the unity side. |
Just posting to put the correct labels, as everything was already described by Dan and fonograph. |
Hi @Nyankoo, @DanForstinger, and @fonograph, I have called the function on both an Android build and the Unity editor at least twenty times, but none of them resulted into an exception or issue. There's a possibility that the issue is related to the device used. In order to verify if this is the case, could you provide the device models along with their respective Android versions? If the issue doesn't persist when using the quickstart, it would be helpful if you provide a minimal, reproducible example of a project with this issue |
Hey @Nyankoo. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @Nyankoo if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
Hi all, I have the same issue.. FirebaseRemoteConfig.FetchAsync(TimeSpan) sometimes (25 to 50% of the time) never returns a result on iOS devices (works well on android devices). Bug occurs on all our iOS devices. Unity editor version: 2020.3.18f1 (also tried some 2019 versions) Here's a code snippet if that can help :
|
@google-oss-bot we are still having this issue, detailed information provided in the comment above, could you please reopen this issue? |
@DellaBitta @paulinon Please re-open the issue, thanks! |
Hi @flogavel, Thanks for the test case. I was able to reproduce the issue by replacing the quickstart code for
Tested this on iOS built with Unity 2020.3.20f1 LTS. Marking this as a bug, thank you! |
For those who are having this issue, we were able to resolve it by making sure that there are ZERO calls to the Firebase SDK before it has finished initializing. In our case, we were calling FirebaseRemoteConfig.DefaultInstance.Keys before CheckAndFixDependenciesAsync has finished calling its callback, which was the trigger to the broken behaviour described here. |
We're awaiting CheckAndFixDependenciesAsync and initiate all other calls to the Firebase SDK after it returns with DependencyStatus.Available, so it seems this is unrelated. |
For those experiencing the issue where Fetch() hangs on iOS, please see #1198 (comment) for more information. For Android, we are still looking into the issue. |
Hey all, Firebase SDK for Unity 8.9.0 is now live, which contains a fix for this issue, and you can download it directly here, or through the usual places like the package manager. I'm going to close this issue for now, but please let us know if there are any outstanding problems. |
@a-maurice Just tested with 8.9.0, and the original issue is still happening when we call |
@a-maurice @DellaBitta Please re-open this issue to continue to keep track of it. |
@Nyankoo are you still seeing it in both Android and the editor? |
@a-maurice This currently only seems to happen in the Editor (tested on Android, not iOS), but I will update here when we released an update to our app and see if the issue still appears in Crashlytics. |
@a-maurice We're still seeing this in Crashlytics happening to our users, so it doesn't seem to be fixed on Android. |
[REQUIRED] Please fill in the following fields:
[REQUIRED] Please describe the issue here:
When setting the cache expiration of
FetchAsync()
toTimeSpan.Zero
(or any other TimeSpan), an exception is thrown withErrorCode 1
. TheMessage
parameter is empty.Steps to reproduce:
Relevant Code:
The text was updated successfully, but these errors were encountered: