Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed metadata name for default notification channel #330

Merged
merged 2 commits into from
Sep 7, 2017
Merged

fixed metadata name for default notification channel #330

merged 2 commits into from
Sep 7, 2017

Conversation

maxost
Copy link
Contributor

@maxost maxost commented Sep 3, 2017

There is incorrect metadata name for default notification channel. I've posted stackoverflow question and got answer from Diego Giorgini. So here is fix.

@samtstern
Copy link
Contributor

@maxost thank you! We really appreciate your coming back with a PR.

cc: @kroikie

@samtstern samtstern merged commit 08d6c2a into firebase:master Sep 7, 2017
@maxost maxost deleted the default-channel-fix branch September 7, 2017 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxost @samtstern