Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify support #2436

Merged
merged 5 commits into from
Jan 8, 2020
Merged

Add verify support #2436

merged 5 commits into from
Jan 8, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Dec 12, 2019 •
edited
Loading

Implements b/135487220.

First pass, not sure what the best failure messages are. I also thought about adding additional tests, but I think the two current ones capture its functionality.

@thebrianchen thebrianchen self-assigned this Dec 12, 2019
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Dec 12, 2019
wilhuff
wilhuff approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

packages/firestore/src/core/transaction.ts Outdated Show resolved Hide resolved
@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Dec 20, 2019
@thebrianchen thebrianchen merged commit 885e0b3 into master Jan 8, 2020
@thebrianchen thebrianchen deleted the bc/verify branch January 8, 2020 14:16
@thebrianchen thebrianchen mentioned this pull request Jan 9, 2020
Merged
@hsubox76 hsubox76 added this to the next milestone Jan 16, 2020
@thebrianchen thebrianchen mentioned this pull request Jan 21, 2020
Open
@firebase firebase locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thebrianchen @wilhuff @hsubox76