-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec tests should not use base64-encoded resume tokens #2759
Labels
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
Steps to reproduce:
In commit 2919c0a, the files
spec_builder.ts
andspec_test_runner.ts
were modified to use base64-encoded resume tokens. Although this makes the tests consistent with the real implementation, it has two undesirable side effects: (1) When tests are exported to Android and iOS viagenerate_spec_json.sh
the resume tokens in the generated JSON files are the base64-encoded resume tokens and (2) It makes the tests that fail due to resume token mismatches more difficult to debug since the resume token cannot be immediately correlated back to the test steps.Since resume tokens are just opaque strings, there is no need to base64 encode them for the spec tests.
The text was updated successfully, but these errors were encountered: