Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md to Nuget and update CONTRIBUTING.md #389

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Apr 5, 2024

Related: #378

@jonathanedey jonathanedey marked this pull request as ready for review April 5, 2024 17:21
@lahirumaramba lahirumaramba linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@jonathanedey jonathanedey merged commit 2b81d3a into je-upgrade Apr 9, 2024
5 checks passed
@jonathanedey jonathanedey deleted the je-platform-upgrade branch April 9, 2024 20:31
jonathanedey added a commit that referenced this pull request Apr 11, 2024
* chore: Bump supported .NET versions to `net462` and `net6.0`  (#377)

* Add net6.0 to targeted frameworks

* Add net6.0 to CI

* fix: update target frameworks for integration tests ans snippets

* Refactor build process and test multiple frameworks

* Refactor build process and test multiple frameworks

* fix script call

* Refactor and update nightly and release workflows

* Trigger Integration Tests

* fix running unit tests in release stage

* fix build before running integration tests

* fix: revert to expected build name

* try only 3.1

* try no specific version

* fix set `Microsoft.NET.Test.Sdk` to 15.0.0

* Add Microsoft.TestPlatform.ObjectModel package for net462

* fix: Update xunit Packages and remove Microsoft.TestPlatform.ObjectModel package for net462

* Fix: tests

* fix: added preprocessor directives to handle differences in tests between .net versions

* Add netcoreapp3.1, net7.0 and net8.0

* fix: Add conditional package references and tests for netcoreapp3.1

* fix conditional test

* Update workflows

* fix: build before running integration tests

* Removed netcoreap3.1 and redundant net7 and net8

* (chore): Upgrade Dependancies (#385)

* [chore] Update Github action workflows to fix node version and `set-output` deprecation warnings (#376)

* Add `README.md` to Nuget and update `CONTRIBUTING.md` (#389)

* Trigger Integration tests

* fix: correct target framework from merge.

* fix: remove previous deprecation note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebaseadmin is missing NuGet package README file
2 participants