Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'instanceOf' to make the use of 'new' optional #191

Merged
merged 3 commits into from
Oct 3, 2016
Merged

Use 'instanceOf' to make the use of 'new' optional #191

merged 3 commits into from
Oct 3, 2016

Conversation

felquis
Copy link
Contributor

@felquis felquis commented Oct 2, 2016

I first tried to use this library like

import fingerPrint from `~/fingerprintjs2`

fingerPrint().get((result, components) => {
  console.log(result, components)
})

I stopped in the error Uncaught TypeError: Cannot read property 'extend' of undefined, I did read about this on JavaScript Patterns.

With this change, will be possible to use fingerPrint without the use of new and the snippets above will work.

@Valve Valve merged commit cfe05db into fingerprintjs:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felquis @Valve