Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not handling xsd:float #278

Closed
ebremer opened this issue Oct 6, 2023 · 2 comments
Closed

Not handling xsd:float #278

ebremer opened this issue Oct 6, 2023 · 2 comments
Milestone
1.3.3

Comments

@ebremer
Copy link
Contributor

ebremer commented Oct 6, 2023

Describe the bug
xsd:double works when using native types, however, xsd:float is not handled

To Reproduce
just user literal data types xsd:float and xsd:double. xsd:float will yield { "@value": "1.0", "@type": "xsd:float" }
whereas xsd:double with yield 1.0 (as expected)
@ebremer
Copy link
Contributor Author

ebremer commented Oct 6, 2023

I see that "2.4.3 - Otherwise, if the datatype IRI of value equals xsd:integer or xsd:double and its lexical form is a valid xsd:integer or xsd:double according [XMLSCHEMA11-2], set converted value to the result of converting the lexical form to a JSON number.", but would it break things if we include xsd:float?

@ebremer ebremer mentioned this issue Oct 7, 2023
Merged
@filip26
Copy link
Owner

filip26 commented Oct 10, 2023

Hi @ebremer , I think it does not break anything as the xsd:float is handled the same way as xsd:double. The PR has been merged. Thanks.

@filip26 filip26 closed this as completed Oct 10, 2023
@filip26 filip26 added this to the 1.3.3 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
2 participants
@filip26 @ebremer