Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling the lang attribute #363

Open
notabene opened this issue Jun 5, 2019 · 3 comments
Open

Styling the lang attribute #363

notabene opened this issue Jun 5, 2019 · 3 comments
Assignees
@ffoodd
Labels
bug

Comments

@notabene
Copy link
Collaborator

notabene commented Jun 5, 2019

Hi @ffoodd

I'm playing with the “check lang” feature and here's how it looks for inline components:
Checking lang with the extension – screenshot.

And here's how it was in my bookmarklet:
Checking lang with bookmarklet – screenshot.

(test page: L’accessibilité dans la formation au numérique)

Before I tinker with the code, is there any reason why you went for a block display for the attribute?

PS : By the way, I'm OK with ::after rather than ::before, it makes sense; I don't know why I went for “before” in the original code 😉
@ffoodd
Copy link
Owner

ffoodd commented Jun 7, 2019

I tried to left align messages with their associated highlighted boxes, without breaking layout.
Most cases best rendered with block display; however it might be time to try another way :)

And briefly searching for this made me think of other enhancements… Opening issues right now!

@notabene
Copy link
Collaborator Author

I was going to open an issue and realized I had already opened one. Duh.

@notabene
Copy link
Collaborator Author

Also, in some cases, like Mastodon, boxes are so constrained that the lang value does not appear at all. The block display overlaps and disappears. 😢

Screenshot from Mastodon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffoodd ffoodd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notabene @ffoodd