Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack ff in deb #115 #206

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

willbasky
Copy link
Contributor

@willbasky willbasky commented Nov 1, 2019

Resolve #115


This change is Reviewable

@willbasky willbasky self-assigned this Nov 1, 2019
@willbasky willbasky changed the title Make deb and test it on travis #115 Pack ff in deb and test it on travis #115 Nov 1, 2019
@willbasky willbasky changed the title Pack ff in deb and test it on travis #115 Pack ff in deb #115 Nov 1, 2019
@willbasky willbasky requested a review from cblp November 1, 2019 16:21
Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @cblp and @willbasky)


.travis.yml, line 52 at r1 (raw file):

      script:
        # Create .deb from binary
        - make deb

и протестировать с помощью lintian


Makefile, line 12 at r1 (raw file):

# prepare deb
.PHONY: deb
deb:

Ради одного скрипта нет смысла мэйкфайл писать, просто скрипт можно.


Makefile, line 17 at r1 (raw file):

	mkdir -p ff-deb/
	mkdir -p ff-deb/usr/bin
	cp $(LOCAL_BINARY_PATH)/bin/$(BIN_NAME) ff-deb/usr/bin/

stack --local-bin-path=ff-deb/usr/bin install ff


Makefile, line 27 at r1 (raw file):

	\nArchitecture: all \
	\nMaintainer: Yuriy Syrovetskiy  \
	\nInstalled-Size: $(LOCAL_FF_SIZE) \

Это обязательное поле?

@willbasky
Copy link
Contributor Author


.travis.yml, line 52 at r1 (raw file):

lintian
мда, линтер выдает ошибки и предупреждения, придется немного по-другому генерить пакет.

@willbasky
Copy link
Contributor Author


Makefile, line 27 at r1 (raw file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

Это обязательное поле?

нет

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @cblp and @willbasky)


Makefile, line 27 at r1 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

нет

тогда убери, меньше мороки

@willbasky
Copy link
Contributor Author


.travis.yml, line 52 at r1 (raw file):
lintian жалуется на статически связанную библиотеку libyaml, которая используется внутри yaml пакета. И кидает ошибку. Не понятно, что с этим делать.
Объяснение линтиана такое:

The given ELF object appears to have been statically linked to a library. Doing this is strongly discouraged due to the extra work needed by the security team to fix all the extra embedded copies or trigger the package rebuilds, as appropriate.
If the package uses a modified version of the given library it is highly recommended to coordinate with the library's maintainer to include the changes on the system version of the library.

Осталось несколько предупреждений, но сначала нужно с ошибкой разобраться, иначе выходит с ошибкой.

@willbasky
Copy link
Contributor Author


Makefile, line 12 at r1 (raw file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

Ради одного скрипта нет смысла мэйкфайл писать, просто скрипт можно.

С мейкфайлом удобнее дебажить.

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @cblp and @willbasky)


.travis.yml, line 52 at r1 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

lintian жалуется на статически связанную библиотеку libyaml, которая используется внутри yaml пакета. И кидает ошибку. Не понятно, что с этим делать.
Объяснение линтиана такое:

The given ELF object appears to have been statically linked to a library. Doing this is strongly discouraged due to the extra work needed by the security team to fix all the extra embedded copies or trigger the package rebuilds, as appropriate.
If the package uses a modified version of the given library it is highly recommended to coordinate with the library's maintainer to include the changes on the system version of the library.

Осталось несколько предупреждений, но сначала нужно с ошибкой разобраться, иначе выходит с ошибкой.

собирай ff динамически, и тогда не надо будет чужие пакеты тащить с собой

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @willbasky)


Makefile, line 12 at r1 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

С мейкфайлом удобнее дебажить.

Если всего одна цель, то менее удобно, по-моему. Или я чего-то не знаю про мэйк?

@willbasky
Copy link
Contributor Author


Makefile, line 12 at r1 (raw file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

Если всего одна цель, то менее удобно, по-моему. Или я чего-то не знаю про мэйк?

он показывает, какую команду выполняет в данный момент и вываливается с ошибкой, если команда не сработала. Для этого не нужно условия писать.

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @willbasky)


Makefile, line 12 at r1 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

он показывает, какую команду выполняет в данный момент и вываливается с ошибкой, если команда не сработала. Для этого не нужно условия писать.

Баш с классическими настройками

#!/bin/bash
set -eux -o pipefail

тоже делает это

@willbasky
Copy link
Contributor Author

I found how to override lintian errors, but not every suppressed. Check it tomorrow.

@willbasky
Copy link
Contributor Author


Makefile, line 12 at r1 (raw file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

Баш с классическими настройками

#!/bin/bash
set -eux -o pipefail

тоже делает это

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack Ubuntu packages
2 participants