Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use custom 'PagerData' protocol for data to avoid unexpected slowness #299

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

use custom 'PagerData' protocol for data to avoid unexpected slowness #299

wants to merge 3 commits into from

Conversation

gfreezy
Copy link

@gfreezy gfreezy commented Sep 25, 2022 •
edited
Loading

Do not convert the input data to array to invalidate lazy effects.

Usecase:

Photos PHFetchResult is a lazy object. Converting it to an array cost a lot of time if you have a large number of photos.

@gfreezy
Copy link
Author

gfreezy commented Sep 25, 2022

Seems SwiftUIPager.xcodeproj is useless. We should remove it to avoid confusion

@gfreezy gfreezy changed the title use custom 'PagerData' protocol for data use custom 'PagerData' protocol for data to avoid unexpected slowness Sep 25, 2022
@gfreezy
callback add item as the second parameter
f15b0d1 
`onPageChanged` `onPageWillChange`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gfreezy