Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All screens should be modal except the main tab screens #507

Open
vmaark opened this issue Sep 18, 2019 · 3 comments
Open

All screens should be modal except the main tab screens #507

vmaark opened this issue Sep 18, 2019 · 3 comments
Labels
design discussion This is a discussion thread which is closed by default enhancement New feature or request usability

Comments

@vmaark
Copy link
Member

vmaark commented Sep 18, 2019

Right now it's easy to end up in the app in not thought through states of the navigation, the different tabs can be deep in a navigation stack, and going back to another tab leads you not to the tab's main screen, but to a place where something was opened previously (in arbitrary depth in a stack).
Also with every new feature where navigation happens as well (or adding a button for a screen to reach it from a new place), we have to consider if it changes the tab - this should not be an issue in this model.
@vmaark vmaark added enhancement New feature or request usability unscheduled Needs to be prioritised design labels Sep 18, 2019
@david-gauquelin
Copy link

Thanks for raising this point @vujevits I had to make some research and reconsider things I took as granted or didn't think through enough. I shared some examples in our Slack channel, but here are my main takeaways:

  • there’s no obvious consensus on what’s best atm
  • on iOS it’s very common to have tabs with navigation and tap again on the tab icon to get back to top level (switching tabs keeps the current navigation level)
  • what feels the best to me is mixed solutions where there are limits on how “deep” you can go within a tab
  • on simple apps (like Transferwise) I think it’s even ok to hide the menu since each tasks require full focus, so cross tab navigation is not so important, but in our case it might be beneficial to keep the tab menu to remind people where they are and allow quick cross section navigation

@vmaark vmaark added discussion This is a discussion thread which is closed by default and removed unscheduled Needs to be prioritised labels Sep 26, 2019
@vmaark
Copy link
Member Author

vmaark commented Sep 26, 2019

At the moment I find our navigation a bit complex, and I would enjoy using a simpler app. Let's just keep this aspect in mind, and continue the discussion if there are new ideas we could implement.

@david-gauquelin
Copy link

oh yeah on that point I fully agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design discussion This is a discussion thread which is closed by default enhancement New feature or request usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmaark @david-gauquelin