Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant arguments #5891

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

elsirion
Copy link
Contributor

Fixes #5843

@elsirion elsirion marked this pull request as ready for review August 20, 2024 13:40
@elsirion elsirion requested review from a team as code owners August 20, 2024 13:40
@elsirion elsirion requested a review from joschisan August 20, 2024 13:41
Copy link
Member

@tvolk131 tvolk131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this part of the codebase, but this seems like a fairly simple change. LGTM!

@joschisan joschisan added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@joschisan joschisan added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@tvolk131 tvolk131 added this pull request to the merge queue Aug 20, 2024
Merged via the queue into fedimint:master with commit 9287bf0 Aug 20, 2024
23 checks passed
@elsirion elsirion deleted the 2024-08-redundant-argument branch August 21, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove superfluous module_instance_id argument
3 participants