feat: gateway can pay invoices as itself #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolk131
force-pushed
the
gateway_pay_normal_invoice
branch
2 times, most recently
from
ede01d1 to
34db077
Compare
Kodylow
requested changes
Aug 15, 2024
tvolk131
force-pushed
the
gateway_pay_normal_invoice
branch
2 times, most recently
from
947c724 to
32528ee
Compare
tvolk131
changed the title
tvolk131
force-pushed
the
gateway_pay_normal_invoice
branch
from
32528ee to
9e96350
Compare
Kodylow
previously approved these changes
Aug 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
feat: gateway can pay invoices as itself
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
m1sterc001guy
requested changes
Aug 22, 2024
tvolk131
force-pushed
the
gateway_pay_normal_invoice
branch
from
9e96350 to
5440279
Compare
Kodylow
previously approved these changes
Aug 26, 2024
| max_fee: max_fee_msats, | ||
| }) | ||
| .await?; | ||
| println!("{response}"); |
There was a problem hiding this comment.
Is there a reason why we're not using print_response?
There was a problem hiding this comment.
Yes, for types that implement std::fmt::Display, print_response() will wrap the value in quotations where as using println!() simply prints the value.
tvolk131
force-pushed
the
gateway_pay_normal_invoice
branch
from
5440279 to
c88021b
Compare
m1sterc001guy
approved these changes
Aug 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin releases/v0.4
git worktree add -d .worktree/backport-5868-to-releases/v0.4 origin/releases/v0.4
cd .worktree/backport-5868-to-releases/v0.4
git switch --create backport-5868-to-releases/v0.4
git cherry-pick -x c88021b4d136d83bc1da79bb76e99eaeac52f6ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gateway can pay invoices as itself (i.e. no e-cash swap, just pay using its own funds)