feat: prepare ptlc support #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschisan
force-pushed
the
lnv2_ptlc
branch
11 times, most recently
from
3482638 to
17d280f
Compare
m1sterc001guy
previously approved these changes
Aug 26, 2024
elsirion
previously approved these changes
Aug 28, 2024
Comment on lines
+182
to
+186
| PaymentImage::Point(pk) => match SecretKey::from_slice(preimage) { | ||
| Ok(sk) => sk.public_key(secp256k1::SECP256K1) == *pk, | ||
| Err(..) => false, | ||
| }, |
There was a problem hiding this comment.
Should we just always make it return false as long as there is no real PTLC spec? Activating some new logic would be comparatively simple (no struct changes, just a new consensus version)
elsirion
approved these changes
Aug 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.