refactor gateway module and further testing #5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschisan
force-pushed
the
lnv2_receive
branch
7 times, most recently
from
cda79c9 to
34eb507
Compare
joschisan
force-pushed
the
lnv2_receive
branch
4 times, most recently
from
3e1435e to
8b8cd8a
Compare
tvolk131
reviewed
Jul 3, 2024
| @@ -1723,20 +1723,26 @@ impl Gateway { | |||
| }) | |||
| } | |||
|
|
|||
| pub async fn select_client_v2( | |||
There was a problem hiding this comment.
Is there a reason we shouldn"t use the existing select_client() method?
There was a problem hiding this comment.
Looks pretty much the same to me
There was a problem hiding this comment.
We want the and anyhow::Result though.
joschisan
force-pushed
the
lnv2_receive
branch
4 times, most recently
from
68f1251 to
e2bfd56
Compare
m1sterc001guy
previously approved these changes
Jul 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
dpc
previously approved these changes
Jul 9, 2024
joschisan
force-pushed
the
lnv2_receive
branch
4 times, most recently
from
296cdd4 to
29ec832
Compare
joschisan
force-pushed
the
lnv2_receive
branch
5 times, most recently
from
038230f to
73658bf
Compare
m1sterc001guy
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.