chore: remove GatewayTest #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sterc001guy
force-pushed
the
remove_gateway_test
branch
from
a81ac81 to
c0efc9b
Compare
|
Needs #5564 |
m1sterc001guy
force-pushed
the
remove_gateway_test
branch
from
c0efc9b to
390fd33
Compare
m1sterc001guy
force-pushed
the
remove_gateway_test
branch
from
390fd33 to
b6b17b8
Compare
joschisan
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards: #5168
This should be one of the last cleanup PRs of the Lightning tests. This PR removes the
GatewayTeststruct.GatewayTestwas just a wrapper aroundGatewaythat started the webserver. The webserver has been a source of issues in the past, we have to poll to wait for it to come up, and it causes flakiness. We do not even need it, everything is in process so we can just directly call functions on the gateway. Now that we have devimint tests, we already have coverage of the webserver too. This PR reduces the scope of the gateway tests to what they should be - module tests :)