feat: manual shutdown of client #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
force-pushed
the
push-nmnstlzvumtw
branch
2 times, most recently
from
ffed3b4 to
99ab9d5
Compare
github-merge-queue
bot
dismissed
dpc’s stale review
The merge-base changed after approval.
dpc
previously approved these changes
Mar 12, 2024
|
Followup: #4535 |
dpc
reviewed
Mar 12, 2024
fedimint-client/src/lib.rs
Outdated
| fedimint_core::task::sleep(Duration::from_millis(10)).await; | ||
| /// Shutdown the client. | ||
| /// Returns false if there are other clones of [`ClientHandle`]. | ||
| pub async fn shutdown(self) -> bool { |
There was a problem hiding this comment.
I feel like this should return a result...
There was a problem hiding this comment.
maybe Result<(), ClientHandle>
There was a problem hiding this comment.
Yeap.
BTW. That Client with stopped reactor is an extra flag and state, that I'm not sure if it's useful for anything ever. Maybe we should cut it. It's easier if "handle exist == it's running" always holds.
So maybe all you can do is "drop" (shutdown), or "restart"? And then shutting down would be infallable? @maan2003
maan2003
force-pushed
the
push-nmnstlzvumtw
branch
2 times, most recently
from
85216a7 to
4fb5f1c
Compare
dpc
approved these changes
Mar 13, 2024
maan2003
force-pushed
the
push-nmnstlzvumtw
branch
from
4fb5f1c to
3ee4640
Compare
justinmoon
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top #4484