fix: avoid warnings on recovery from mid session crash #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschisan
force-pushed
the
ignore_uncommitted
branch
from
a637c1f to
664aa75
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3775 +/- ##
==========================================
- Coverage 57.71% 57.69% -0.03%
==========================================
Files 193 193
Lines 42055 42053 -2
==========================================
- Hits 24273 24261 -12
- Misses 17782 17792 +10 ☔ View full report in Codecov by Sentry. |
elsirion
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
I think this approach works well for this particular case but should otherwise be discouraged. What do you think @dpc? The alternative would be disabling the warning also on the other early return, which would be more standard.
|
Waiting for DPC ;) |
dpc
approved these changes
Nov 28, 2023
|
LGTM. The less mutation, the better, but whatever is simpler works, and it"s all just diagnostics anyway. |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.