feat: Support re-attempt LN invoice payment #3322

m1sterc001guy · 2023-10-02T21:51:25Z

Intuition: adds an index into the OperationId hash so that multiple attempts to pay the same invoice are allowed. When creating the contract, the client checks to see if the contract (incoming or outgoing) already exists, and returns an error if it already does. If it does not, the index is incremented and committed to the database (this serves as a de-facto lock which prevents multiple threads from payment the same invoice at the same time).

When the payment is successful, the PayType and ContractId are stored in the database, which allows subsequent payment attempts to just lookup the succuessful payment in the operation log, rather than re-initiating the payment.

Open to suggestions on how to better test this.

codecov · 2023-10-02T22:11:09Z

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (c83d7a9) 60.16% compared to head (f049733) 60.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3322       /-   ##
==========================================
  Coverage   60.16%   60.34%    0.18%     
==========================================
  Files         193      193              
  Lines       40361    40510      149     
==========================================
  Hits        24283    24447      164     
  Misses      16078    16063      -15

Files	Coverage Δ
fedimint-client/src/lib.rs	`77.68% <100.00%> ( 0.18%)`	⬆️
gateway/ln-gateway/src/state_machine/mod.rs	`91.38% <100.00%> ( 0.02%)`	⬆️
modules/fedimint-ln-client/src/db.rs	`33.33% <66.66%> ( 16.66%)`	⬆️
modules/fedimint-ln-client/src/incoming.rs	`88.43% <93.33%> ( 0.16%)`	⬆️
modules/fedimint-ln-client/src/pay.rs	`90.47% <96.87%> ( 4.62%)`	⬆️
fedimint-load-test-tool/src/common.rs	`0.00% <0.00%> (ø)`
fedimint-wasm-tests/src/lib.rs	`0.00% <0.00%> (ø)`
fedimint-cli/src/client.rs	`0.00% <0.00%> (ø)`
modules/fedimint-ln-client/src/lib.rs	`87.92% <80.19%> (-0.58%)`	⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

modules/fedimint-ln-common/src/api.rs

modules/fedimint-ln-client/src/lib.rs

modules/fedimint-ln-client/src/db.rs

elsirion

Looks good enough, I have some ideas how to improve, but happy to merge.

modules/fedimint-ln-client/src/lib.rs

justinmoon · 2023-10-23T16:20:22Z

Call: @m1sterc001guy could you backport if easy

m1sterc001guy · 2023-10-23T18:57:22Z

This one is unfortunately difficult. Major conflicts in lots of files :/

TonyGiorgio · 2024-01-09T16:31:07Z

@justinmoon @m1sterc001guy curious if this one ended up being backported to 0.2. I ran into this, and combined with the lack of canceled state update (#4014), causes some problems on our side. I think it's pretty common for users to attempt a payment again if the first one failed.

m1sterc001guy · 2024-01-09T16:36:52Z

Yes, I see it in the release branch, here is one of the commits. What issue are you seeing? Maybe it's not covered by this fix.

TonyGiorgio · 2024-01-09T16:40:12Z

Seems like it timed out making the payment, refunded the ecash, then another attempt at paying the same invoice has issues.

Here's some logs:

docker-lnd-1          | 2024-01-09 16:15:38.764 [ERR] CRTR: Payment 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757 failed: timeout                                                                           
docker-gatewayd-1     | 2024-01-09T16:15:38.763931Z  INFO ln_gateway::lnd: LND payment failed for invoice PrunedInvoice { amount: Amount { msats: 200000000 }, ....

...

docker-gatewayd-1     | 2024-01-09T16:15:38.764442Z  WARN ln_gateway::state_machine::pay: Failed to buy preimage with Payment failed: FailureReasonTimeout for contract OutgoingContractAccount { amount: Amount { msats: 20200
1000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12c
b436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(37fafdb56876e649ef187b4e77f28ca5f7b9617acc7e38133419a236ed8cc55f1a67468217c71267d06afae9be094b3f14ba8173e6a7e5229557ee67fd948c1b), cancelled: fal
se } }
docker-gatewayd-1     | 2024-01-09T16:15:38.764637Z  INFO state_machine_transition{operation_id=ea3cde29a10e9a9305bb5d9f27b9acad70074f79b28db4c7b499f7676f674f68}: fedimint_client::sm::executor: Executing state transition
docker-gatewayd-1     | 2024-01-09T16:15:38.765518Z  INFO state_machine_transition{operation_id=ea3cde29a10e9a9305bb5d9f27b9acad70074f79b28db4c7b499f7676f674f68}: fedimint_client::sm::executor: Executing state transition
docker-gatewayd-1     | 2024-01-09T16:15:38.765563Z  INFO state_machine_transition{operation_id=ea3cde29a10e9a9305bb5d9f27b9acad70074f79b28db4c7b499f7676f674f68}: ln_gateway::state_machine::pay: Canceling outgoing contract 
OutgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d
53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(37fafdb56876e649ef187b4e77f28ca5f7b9617acc7e38133419a236ed8cc55f1a67468217c71267d06afae9be
094b3f14ba8173e6a7e5229557ee67fd948c1b), cancelled: false } }
docker-gatewayd-1     | 2024-01-09T16:15:38.765919Z  INFO state_machine_transition{operation_id=ea3cde29a10e9a9305bb5d9f27b9acad70074f79b28db4c7b499f7676f674f68}: ln_gateway::state_machine::pay: Canceled outgoing contract O
utgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d5
3b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(37fafdb56876e649ef187b4e77f28ca5f7b9617acc7e38133419a236ed8cc55f1a67468217c71267d06afae9be0
94b3f14ba8173e6a7e5229557ee67fd948c1b), cancelled: false } } with txid ad780a45debf7f64c538312c542b771e5edb92dbfc70c8b65bda878ad8385d21
docker-gatewayd-1     | 2024-01-09T16:15:39.781542Z  INFO state_machine_transition{operation_id=ea3cde29a10e9a9305bb5d9f27b9acad70074f79b28db4c7b499f7676f674f68}: fedimint_client::sm::executor: Executing state transition

...

docker-gatewayd-1     | 2024-01-09T16:23:59.084254Z  INFO ln_gateway::lnd: LND Paying invoice PrunedInvoice { amount: Amount { msats: 200000000 }, 
destination: PublicKey(028fe7cb1b6cd6bac7f5c9c4eff166fdb73ab861595e5b7f69b099bb32091dccede5828671f691268fc4cf1937989d30aa0a6213c0117103d3e7b553455cf313), destination_features: [2, 66, 0], payment_hash: 1444022cb98afdaf1197c
bc005918b49f7c0f6171f25457a5ef51307a84b8757, payment_secret: [160, 183, 202, 202, 171, 76, 233, 139, 132, 87, 249, 15, 23, 245, 253, 87, 189, 160, 1, 55, 83, 107, 20, 248, 209, 13, 209, 45, 229, 240, 253, 150], route_hints:
 [], min_final_cltv_delta: 80, expiry_timestamp: 1704820307 }
docker-gatewayd-1     | 2024-01-09T16:23:59.133717Z  WARN ln_gateway::state_machine::pay: Failed to buy preimage with Payment failed: FailureReasonTimeout for contract OutgoingContractAccount { amount: Amount { msats: 20200
1000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12c
b436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: fal
se } }
docker-gatewayd-1     | 2024-01-09T16:23:59.134071Z  INFO state_machine_transition{operation_id=2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5}: fedimint_client::sm::executor: Executing state transition
docker-gatewayd-1     | 2024-01-09T16:23:59.134937Z  INFO state_machine_transition{operation_id=2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5}: fedimint_client::sm::executor: Executing state transition
docker-gatewayd-1     | 2024-01-09T16:23:59.135112Z  INFO pay_invoice: ln_gateway::state_machine: Got state CancelContract(GatewayPayCancelContract { contract: OutgoingContractAccount { amount: Amount { msats: 202001000 }, 
contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f8
64b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }, 
error: OutgoingPaymentError { error_type: LightningPayError { lightning_error: FailedPayment { failure_reason: "FailureReasonTimeout" } }, contract_id: 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5, contr
act: Some(OutgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a9
23ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e4
23131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }) } }) while awaiting for output of 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5
docker-gatewayd-1     | 2024-01-09T16:23:59.134980Z  INFO state_machine_transition{operation_id=2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5}: ln_gateway::state_machine::pay: Canceling outgoing contract 
OutgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d
53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3a
dd388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }
docker-gatewayd-1     | 2024-01-09T16:23:59.136268Z  INFO state_machine_transition{operation_id=2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5}: ln_gateway::state_machine::pay: Canceled outgoing contract O
utgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d5
3b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3ad
d388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } } with txid a7ce28ee28ae4c9a1c58b04346c083f0e473ab558d5e1a1ee3feece3c1f21d5a
docker-gatewayd-1     | 2024-01-09T16:24:00.149419Z  INFO state_machine_transition{operation_id=2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5}: fedimint_client::sm::executor: Executing state transition
docker-gatewayd-1     | 2024-01-09T16:24:00.150476Z ERROR pay_invoice: ln_gateway: Cancelled with OutgoingContractError: An error occurred while paying the lightning invoice. while paying invoice: 2688a6c02cce1c07af8fe0f0e1
fb13fc9f03da80c8b9c2154b530dc7bd6bded5
docker-gatewayd-1     | 2024-01-09T16:24:00.150534Z ERROR pay_invoice: ln_gateway::rpc::rpc_server: error=Outgoing Payment Error OutgoingContractError: An error occurred while paying the lightning invoice.
docker-gatewayd-1     | 2024-01-09T16:24:02.142045Z  INFO pay_invoice: ln_gateway::state_machine: State machine for operation 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5 already exists, will not add a n
ew one
docker-gatewayd-1     | 2024-01-09T16:24:02.142793Z  INFO pay_invoice: ln_gateway::state_machine: Got state CancelContract(GatewayPayCancelContract { contract: OutgoingContractAccount { amount: Amount { msats: 202001000 }, 
contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f8
64b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }, 
error: OutgoingPaymentError { error_type: LightningPayError { lightning_error: FailedPayment { failure_reason: "FailureReasonTimeout" } }, contract_id: 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5, contr
act: Some(OutgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a9
23ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e4
23131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }) } }) while awaiting for output of 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5
docker-gatewayd-1     | 2024-01-09T16:24:02.143237Z ERROR pay_invoice: ln_gateway: Cancelled with OutgoingContractError: An error occurred while paying the lightning invoice. while paying invoice: 2688a6c02cce1c07af8fe0f0e1
fb13fc9f03da80c8b9c2154b530dc7bd6bded5
docker-gatewayd-1     | 2024-01-09T16:24:02.143558Z ERROR pay_invoice: ln_gateway::rpc::rpc_server: error=Outgoing Payment Error OutgoingContractError: An error occurred while paying the lightning invoice.
docker-gatewayd-1     | 2024-01-09T16:24:04.369326Z  INFO pay_invoice: ln_gateway::state_machine: State machine for operation 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5 already exists, will not add a n
ew one
docker-gatewayd-1     | 2024-01-09T16:24:04.370007Z  INFO pay_invoice: ln_gateway::state_machine: Got state CancelContract(GatewayPayCancelContract { contract: OutgoingContractAccount { amount: Amount { msats: 202001000 }, 
contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f8
64b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }, 
error: OutgoingPaymentError { error_type: LightningPayError { lightning_error: FailedPayment { failure_reason: "FailureReasonTimeout" } }, contract_id: 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5, contr
act: Some(OutgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a9
23ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e4
23131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }) } }) while awaiting for output of 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5
docker-gatewayd-1     | 2024-01-09T16:24:04.370180Z ERROR pay_invoice: ln_gateway: Cancelled with OutgoingContractError: An error occurred while paying the lightning invoice. while paying invoice: 2688a6c02cce1c07af8fe0f0e1
fb13fc9f03da80c8b9c2154b530dc7bd6bded5
docker-gatewayd-1     | 2024-01-09T16:24:04.370203Z ERROR pay_invoice: ln_gateway::rpc::rpc_server: error=Outgoing Payment Error OutgoingContractError: An error occurred while paying the lightning invoice.

...

And that error repeats over and over again, presumably due to the lack of canceled update. Is there anything I should do on the client side to ensure that it's a new contract/operational id?

m1sterc001guy · 2024-01-09T17:58:26Z

I think this is another instance of the LN state update stream not yielding the Cancelled state. From your logs, it looks like the previous contract hasn't been cancelled yet:

docker-gatewayd-1     | 2024-01-09T16:24:04.370007Z  INFO pay_invoice: ln_gateway::state_machine: Got state CancelContract(GatewayPayCancelContract { contract: OutgoingContractAccount { amount: Amount { msats: 202001000 },
contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a923ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f8
64b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e423131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } },
error: OutgoingPaymentError { error_type: LightningPayError { lightning_error: FailedPayment { failure_reason: "FailureReasonTimeout" } }, contract_id: 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5, contr
act: Some(OutgoingContractAccount { amount: Amount { msats: 202001000 }, contract: OutgoingContract { hash: 1444022cb98afdaf1197cbc005918b49f7c0f6171f25457a5ef51307a84b8757, gateway_key: PublicKey(b81ca3e6ea9ed786736fa265a9
23ac7af71d53b6b48a40d06c7593433f4cf18d14dc2ce8d12e3771905629cb12cb436f9f864b3f569f5b5f4ba905a3f41cf737), timelock: 825521, user_key: PublicKey(1ef999da47fb3b55d2547a3a0934b4c1ebccd92a651a69f515b9eba7626bc823e48d3415e83ee3e4
23131b8b3add388789f9f6177f6fd01a19555cdcee2c9769), cancelled: false } }) } }) while awaiting for output of 2688a6c02cce1c07af8fe0f0e1fb13fc9f03da80c8b9c2154b530dc7bd6bded5

And since the payment has the same contract id, the gateway won't attempt to re-pay the same contract until the previous one is gone. #4014

Also, when investigating this, I think we also have a bug on the client side where it's possible the client transitions after 30 seconds, but the payment could be successful after that. #4021

m1sterc001guy force-pushed the reattempt_ln_pay branch from f249063 to 8a69351 Compare October 2, 2023 22:04

m1sterc001guy mentioned this pull request Oct 3, 2023

refactor: rename fetch_contract -> wait_contract #3319

Merged

m1sterc001guy force-pushed the reattempt_ln_pay branch from 8a69351 to 4500812 Compare October 3, 2023 18:58

m1sterc001guy marked this pull request as ready for review October 3, 2023 18:58

m1sterc001guy requested review from a team as code owners October 3, 2023 18:58

elsirion reviewed Oct 10, 2023

View reviewed changes

modules/fedimint-ln-common/src/api.rs Outdated Show resolved Hide resolved

modules/fedimint-ln-client/src/lib.rs Outdated Show resolved Hide resolved

m1sterc001guy force-pushed the reattempt_ln_pay branch from 4500812 to 7fed678 Compare October 10, 2023 18:44

elsirion reviewed Oct 11, 2023

View reviewed changes

modules/fedimint-ln-client/src/lib.rs Outdated Show resolved Hide resolved

m1sterc001guy force-pushed the reattempt_ln_pay branch from bf835c8 to 6c97c46 Compare October 12, 2023 17:57

elsirion reviewed Oct 13, 2023

View reviewed changes

modules/fedimint-ln-client/src/db.rs Outdated Show resolved Hide resolved

elsirion previously approved these changes Oct 13, 2023

View reviewed changes

modules/fedimint-ln-client/src/lib.rs Show resolved Hide resolved

m1sterc001guy dismissed elsirion’s stale review via 12d50ea October 16, 2023 20:56

m1sterc001guy force-pushed the reattempt_ln_pay branch from 6c97c46 to 12d50ea Compare October 16, 2023 20:56

elsirion enabled auto-merge October 17, 2023 16:28

m1sterc001guy added 4 commits October 17, 2023 14:10

feat: support re-attempting LN invoice payment

601c61c

feat: add get_active_states to client

662eea5

feat: include gateway fee in PaymentResult

8f9a171

feat: add check for empty contract and OutgoingLightningPayment struct

f049733

m1sterc001guy force-pushed the reattempt_ln_pay branch from 12d50ea to f049733 Compare October 17, 2023 19:11

elsirion approved these changes Oct 18, 2023

View reviewed changes

elsirion added this pull request to the merge queue Oct 18, 2023

Merged via the queue into fedimint:master with commit e536500 Oct 18, 2023
19 checks passed

TonyGiorgio mentioned this pull request Jan 9, 2024

Don't allow invoice re-attempts for fedimint MutinyWallet/mutiny-node#951

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support re-attempt LN invoice payment #3322

feat: Support re-attempt LN invoice payment #3322

m1sterc001guy commented Oct 2, 2023

codecov bot commented Oct 2, 2023 •

edited

Loading

elsirion left a comment

justinmoon commented Oct 23, 2023

m1sterc001guy commented Oct 23, 2023

TonyGiorgio commented Jan 9, 2024

m1sterc001guy commented Jan 9, 2024

TonyGiorgio commented Jan 9, 2024 •

edited

Loading

m1sterc001guy commented Jan 9, 2024

feat: Support re-attempt LN invoice payment #3322

feat: Support re-attempt LN invoice payment #3322

Conversation

m1sterc001guy commented Oct 2, 2023

codecov bot commented Oct 2, 2023 • edited Loading

Codecov Report

elsirion left a comment

Choose a reason for hiding this comment

justinmoon commented Oct 23, 2023

m1sterc001guy commented Oct 23, 2023

TonyGiorgio commented Jan 9, 2024

m1sterc001guy commented Jan 9, 2024

TonyGiorgio commented Jan 9, 2024 • edited Loading

m1sterc001guy commented Jan 9, 2024

codecov bot commented Oct 2, 2023 •

edited

Loading

TonyGiorgio commented Jan 9, 2024 •

edited

Loading