-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Gatewayd to UI via API #2323
Conversation
@IgboPharaoh you might be interested in this specific work item |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master fedimint/fedimint#2323 /- ##
==========================================
- Coverage 59.94% 58.69% -1.26%
==========================================
Files 154 159 5
Lines 32263 34128 1865
==========================================
Hits 19341 20031 690
- Misses 12922 14097 1175
... and 69 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
How to test it? |
Here is a pre-filled yarn start with a test password to one of the gateways we spin up in tmuxinator
You should see a live gateway UI connected to gatewayd. Test the functionality, and take note of bugs |
Hello @okjodom I'll like to pick up this issue and work on it. I'm currently looking at the current implementation of the API spec you made in the commits |
|
||
// RealMintgate makes API calls to a given Mintgate API | ||
export class RealMintgate implements Mintgate { | ||
private readonly password: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IgboPharaoh , debug this line
Connect Gateway UI to a gatewayd instance.
Assumes a gatewayd REST api which is the current reality, but we should switch to a JSON RPC API as proposed by #2293
Closes fedimint/ui#20