chore: get rid of openssl #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkitman
force-pushed
the
openssl
branch
2 times, most recently
from
73ab184 to
8c49c9d
Compare
|
Fails during |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2305 /- ##
==========================================
- Coverage 59.88% 59.12% -0.77%
==========================================
Files 158 159 1
Lines 33415 33919 504
==========================================
Hits 20009 20053 44
- Misses 13406 13866 460
... and 45 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
justinmoon
reviewed
Apr 26, 2023
| jsonrpsee-types = "0.16.0" | ||
| jsonrpsee-core = { version = "0.16.2", features = [ "client" ] } | ||
| # TODO: use official release, but right now there's a bug that stalls our client | ||
| jsonrpsee-types = { version = "0.18.0" } |
There was a problem hiding this comment.
I don't think this comment is relevant anymore?
justinmoon
reviewed
Apr 26, 2023
| jsonrpsee-types = "0.16.0" | ||
| jsonrpsee-core = { version = "0.16.2", features = [ "client" ] } | ||
| # TODO: use official release, but right now there's a bug that stalls our client | ||
| jsonrpsee-types = "0.18.0" |
There was a problem hiding this comment.
can remove this comment
justinmoon
approved these changes
Apr 26, 2023
dpc
reviewed
Apr 26, 2023
| @@ -54,6 54,12 @@ function check_forbidden_dependencies() { | |||
| return 1 | |||
| fi | |||
| done | |||
| find ./ -name Cargo.lock | while read -r cargo_lock ; do | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200