fix: remove gatewayd reconnect expects #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2173 /- ##
==========================================
- Coverage 60.20% 60.05% -0.16%
==========================================
Files 152 152
Lines 31046 31054 8
==========================================
- Hits 18692 18649 -43
- Misses 12354 12405 51
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dpc
reviewed
Apr 7, 2023
elsirion
reviewed
Apr 9, 2023
m1sterc001guy
force-pushed
the
reconnect_expect
branch
from
02bb83f to
b80996a
Compare
Closed
dpc
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When actors in
gatewaydare processing htlcs, they wait on two futures (one is a signal that the thread should shutdown, the other is the htlc sent from the lightning node).There is a race condition currently where we try to send a "shutdown" signal over a channel that then returns an error. This can happen during shutdown, where the webserver and the connection to the lightning node shutdown at the same time. Currently, we have some
expectsthat will crashgatewaydif it can't send over the channel. This PR changes it to remove theexpectsso thatgatewayddoesn't crash in this case.