Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete the dev container #2156

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Apr 6, 2023

During deep dive it was pointed out that macos nix issues are largely resolved, and we don't know of any person actually using it.

It might be an extra source of confusion, and if no one is actively using it might be broken.

Closes #2152

During deep dive it was pointed out that macos nix issues are largely
resolved, and we don't know of any person actually using it.

It might be an extra source of confusion, and if no one is actively
using it might be broken.
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (edfae67) 60.25% compared to head (3d4e96d) 60.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2156    /-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files         152      152           
  Lines       30924    30924           
=======================================
  Hits        18634    18634           
  Misses      12290    12290           

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maan2003

This comment was marked as duplicate.

@justinmoon justinmoon merged commit 4d95fb8 into fedimint:master Apr 7, 2023
@dpc dpc deleted the delete-devcontainer branch April 7, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix devcontainer build or remote it
3 participants