feat: Spawn electrs and esplora in fedimint-bin-tests #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
reviewed
Apr 5, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2125 /- ##
==========================================
- Coverage 60.46% 60.29% -0.17%
==========================================
Files 152 152
Lines 30873 30913 40
==========================================
- Hits 18666 18638 -28
- Misses 12207 12275 68
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Feel free to do esplora as well. It should be very similar. |
gotlougit
changed the title
|
Now we spawn esplora in |
maan2003
reviewed
Apr 5, 2023
maan2003
reviewed
Apr 5, 2023
dpc
approved these changes
Apr 5, 2023
ayush-ranjan-official
pushed a commit
to ayush-ranjan-official/fedimint
that referenced
this pull request
Apr 5, 2023
|
Great PR @gotlougit! |
GetPsyched
pushed a commit
to GetPsyched/fedimint
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to partially address #2101 issue 5, and will help migrate the remaining portions of Fedimint's testing infra to Rust away from Bash scripts.