Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tmuxinator runs 4 panes tailing each fedimintd log #2118

Merged
merged 1 commit into from
Apr 5, 2023
Merged

feat: Tmuxinator runs 4 panes tailing each fedimintd log #2118

merged 1 commit into from
Apr 5, 2023

Conversation

justinmoon
Copy link
Contributor

@justinmoon justinmoon commented Apr 4, 2023 •
edited
Loading

Closes #1937

image

justinmoon
justinmoon commented Apr 4, 2023
View reviewed changes
.tmuxinator.yml
@@ -21,8 21,14 @@ windows:
- source scripts/tmux-user-shell.sh
- federation:
panes:
- federation:
- tail -n 0 -F $FM_LOGS_DIR/fedimint-*.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$FM_LOGS_DIR/fedimint-*.log was slightly wrong. Logs are in $FM_LOGS_DIR/fedimintd-*.log. Missing the d in fedimintd.

mxz42
mxz42 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@mxz42 mxz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks 👍

@mxz42
Copy link
Contributor

mxz42 commented Apr 4, 2023

The distributed key generation log is also mentioned in #1937.
just as remark: it can be found in cat $FM_LOGS_DIR/fedimint-dev.log

@justinmoon
Copy link
Contributor Author

justinmoon commented Apr 4, 2023 •
edited
Loading

The distributed key generation log is also mentioned in #1937. just as remark: it can be found in cat $FM_LOGS_DIR/fedimint-dev.log

Yea so after #1910, the "federation" tmuxinator pane no longer spawns dkg itself. Instead, dkg (along with everything else) gets spawned here before tmux itself is launched. It runs in background and logs to file.

So it's a little weird that the DKG logs don't show up visually in tmuxinator anymore. But DKG should hopefully (🤞) never fail in tmuxinator. Perhaps we could have each DKG instance log to fedimintd-<n>.log like fedimintd does? I think that might be an improvement.

@justinmoon justinmoon mentioned this pull request Apr 5, 2023
Closed
@maan2003 maan2003 merged commit 4572910 into fedimint:master Apr 5, 2023
@justinmoon justinmoon deleted the tmux-windowz branch April 5, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxz42 mxz42 mxz42 approved these changes

@maan2003 maan2003 maan2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create more windows in tmuxinator
3 participants
@justinmoon @mxz42 @maan2003