Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client NG 5: mint module works end-to-end #2109

Merged
merged 20 commits into from
Apr 18, 2023
Merged

Client NG 5: mint module works end-to-end #2109

merged 20 commits into from
Apr 18, 2023

Conversation

elsirion
Copy link
Contributor

@elsirion elsirion commented Apr 4, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 35.85% and project coverage change: -0.22 ⚠️

Comparison is base (00ca848) 59.89% compared to head (09f9c28) 59.68%.

❗ Current head 09f9c28 differs from pull request most recent head 55d9dc3. Consider uploading reports for the commit 55d9dc3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2109       /-   ##
==========================================
- Coverage   59.89%   59.68%   -0.22%     
==========================================
  Files         154      158        4     
  Lines       32260    33336     1076     
==========================================
  Hits        19323    19896      573     
- Misses      12937    13440      503
Impacted Files Coverage Δ
fedimint-cli/src/ng.rs 0.00% <0.00%> (ø)
fedimint-client/src/db.rs 0.00% <0.00%> (ø)
fedimint-client/src/module/gen.rs 9.45% <0.00%> (-6.10%) ⬇️
fedimint-client/src/module/mod.rs 0.00% <0.00%> (ø)
fedimint-client/src/transaction/builder.rs 49.39% <0.00%> (-27.97%) ⬇️
fedimint-client/src/lib.rs 3.66% <4.27%> (-3.06%) ⬇️
fedimint-cli/src/lib.rs 5.50% <4.54%> (-0.16%) ⬇️
fedimint-client/src/sm/state.rs 90.81% <14.28%> ( 0.29%) ⬆️
modules/fedimint-ln-client/src/lib.rs 2.50% <20.00%> (ø)
modules/fedimint-wallet-client/src/lib.rs 2.50% <20.00%> (ø)
... and 14 more

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justinmoon justinmoon mentioned this pull request Apr 4, 2023
Merged
@elsirion elsirion force-pushed the 2023-04-client-ng-5 branch 10 times, most recently from 2c0519a to 8dceafa Compare April 17, 2023 10:12
elsirion added 18 commits April 17, 2023 22:16
@elsirion
fix: minor nits from fedimint#1985
3887b92
@elsirion
fix: rename trigger_* fns to await_*
73c7d8d
@elsirion
fix: generic naming for mint state machine structs
5c48a5f
@elsirion
fix: propagate client secret to modules
682bb75
@elsirion
feat: implement MintClientModule::create_input
37cc50c
@elsirion
fix: make mint client primary client module
db45d42
@elsirion
fix: allow mint input creation from external notes
c3faf51
@elsirion
feat: implement state machine executor notifications
0edf193
@elsirion
fix: use new notification API for awaiting transaction confirmation
31b63f4
@elsirion
feat: implement mint client await_output_finalized
7d90a3b
@elsirion
fix: add as_any to IClientModule
4c02757
@elsirion
fix: allow recursive dyn decoding
0274a74
@elsirion
fix: add more logging if instance id wasn't found
28f4160
@elsirion
fix: initialize primary client module
b1dadca
@elsirion
fix: use client decoders that support state machine decoding
c68cc84
@elsirion
fix: don't panic on mint output subscription returning prematurely
353ed86
@elsirion
fix: allow accessing module clients
5e7e62c
@elsirion
feat: add subcommand to fedimint-cli for testing client ng
ec4424c
@elsirion elsirion force-pushed the 2023-04-client-ng-5 branch from b4340d4 to 55d9dc3 Compare April 17, 2023 20:24
@elsirion elsirion changed the title WIP: Client NG 5 Client NG 5: mint module works end-to-end Apr 17, 2023
@elsirion elsirion marked this pull request as ready for review April 17, 2023 20:29
@elsirion elsirion requested review from a team as code owners April 17, 2023 20:29
@elsirion elsirion force-pushed the 2023-04-client-ng-5 branch 2 times, most recently from 09f9c28 to 55d9dc3 Compare April 18, 2023 16:16
@elsirion elsirion mentioned this pull request Apr 18, 2023
Merged
@dpc dpc merged commit 0866833 into fedimint:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpc dpc dpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsirion @dpc