-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean&unify --data-dir
argument to fedimintd and fedimint-cli
#2063
Conversation
dpc
commented
Mar 29, 2023
- Make it possible to pass by env variable
- Make it always explicit, not positional
- Use the same name (keep an alias for easier transation)
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2063 /- ##
==========================================
- Coverage 62.76% 62.74% -0.02%
==========================================
Files 144 144
Lines 29266 29267 1
==========================================
- Hits 18369 18365 -4
- Misses 10897 10902 5
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -70,7 70,7 @@ mkdir -p $FM_GATEWAY_DATA_DIR | |||
export FM_LIGHTNING_CLI="lightning-cli --network regtest --lightning-dir=$FM_CLN_DIR" | |||
export FM_LNCLI="lncli -n regtest --lnddir=$FM_LND_DIR --rpcserver=localhost:11009" | |||
export FM_BTC_CLIENT="bitcoin-cli -regtest -rpcuser=bitcoin -rpcpassword=bitcoin" | |||
export FM_MINT_CLIENT="$FM_BIN_DIR/fedimint-cli --workdir $FM_CFG_DIR" | |||
export FM_MINT_CLIENT="$FM_BIN_DIR/fedimint-cli --data-dir $FM_CFG_DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we replace this with env variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe sometime. But for now I think making it as much 1:1 change is best.
* Make it possible to pass by env variable * Make it always explicit, not positional * Use the same name (keep an alias for easier transation)
So our target for the patch ( Also, I was expecting that |