chore: debug build with release-profile level of debug symbols #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before (`nix build #.debug.workspaceBuild`, uncompressed => compressed): ``` fedimint-workspace-build> /*stdin*\ : 17.83% ( 9.16 GiB => 1.63 GiB, /nix/store/mfy5k84rxqfh3x7ss3wwnyxf8z1zv752-fedimint-workspace-build-0.0.1/target.tar.zst) ``` After: ``` fedimint-workspace-build> /*stdin*\ : 17.46% ( 6.57 GiB => 1.15 GiB, /nix/store/j7gh6rsi65g2ld3z3wkqdn8ymfyjl7j4-fedimint-workspace-build-0.0.1/target.tar.zst) ``` According to https://users.rust-lang.org/t/keeping-debug-info-but-smaller/55009/3 `debug=1` is the same level that release build uses, which should be adequate to our needs. If anyone ever complains I'll introduce a new custom build level.
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #2047 /- ##
==========================================
Coverage 61.76% 61.77% 0.01%
==========================================
Files 144 144
Lines 28882 28882
==========================================
Hits 17838 17843 5
Misses 11044 11039 -5 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dpc
changed the title
Move `debug=1` to a custom `ci` build profile, to leave the debug mode as it was before.
jkitman
approved these changes
Mar 28, 2023
I don't see any, but chances are I'm just missing something. :D It's not going to be difficult to revert though, so should be fine. |
justinmoon
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (
nix build #.debug.workspaceBuild, uncompressed => compressed):After:
According to https://users.rust-lang.org/t/keeping-debug-info-but-smaller/55009/3
debug=1is the same level that release build uses, which should be adequate for CI.BTW. If you're curious,
debug=0produces: