Make sure other peers received all our dkg messages #1424

dpc · 2023-01-20T00:57:45Z

dpc · 2023-01-20T07:31:35Z

fedimintd/src/distributedgen.rs

@@ -101,6  102,12 @@ pub async fn run_dkg(
    )
    .await?;

+    // When testing on localhost, it's possible to get


I'm so sloppy. I wrote all this flushing, to avoid this hack and yet I still pushed it in the PR. 🤦

In fedimint#1424 I first wrote this workaround, then decided it's meh, then wrote rest of the fedimint#1424 with a proper solution, and forgot to delete the workaround.

In #1424 I first wrote this workaround, then decided it's meh, then wrote rest of the #1424 with a proper solution, and forgot to delete the workaround.

Make sure other peers received all our dkg messages

4c5d4a3

Fix fedimint#1405

elsirion approved these changes Jan 20, 2023

View reviewed changes

elsirion merged commit ce76f01 into fedimint:master Jan 20, 2023

dpc deleted the dkg-completion-sync branch January 20, 2023 02:57

dpc commented Jan 20, 2023

View reviewed changes

dpc added a commit to dpc/fedimint that referenced this pull request Jan 20, 2023

Delete unnecessary workaround

da63c2f

In fedimint#1424 I first wrote this workaround, then decided it's meh, then wrote rest of the fedimint#1424 with a proper solution, and forgot to delete the workaround.

dpc mentioned this pull request Jan 20, 2023

Delete unnecessary workaround #1427

Merged

justinmoon pushed a commit that referenced this pull request Jan 23, 2023

Delete unnecessary workaround

140ff59

In #1424 I first wrote this workaround, then decided it's meh, then wrote rest of the #1424 with a proper solution, and forgot to delete the workaround.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure other peers received all our dkg messages #1424

Make sure other peers received all our dkg messages #1424

dpc commented Jan 20, 2023

dpc Jan 20, 2023 •

edited

Loading

Make sure other peers received all our dkg messages #1424

Make sure other peers received all our dkg messages #1424

Conversation

dpc commented Jan 20, 2023

dpc Jan 20, 2023 • edited Loading

Choose a reason for hiding this comment

dpc Jan 20, 2023 •

edited

Loading