Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.json obsolete? #3292

Closed
EthnTuttle opened this issue Sep 25, 2023 · 4 comments
Closed

client.json obsolete? #3292

EthnTuttle opened this issue Sep 25, 2023 · 4 comments
Assignees
Labels

Comments

@EthnTuttle
Copy link
Contributor

When experimenting with fedimint-cli and modules, it seems that the client.json file is no longer used since the config is sourced from the client.db/ directory.

@EthnTuttle
Copy link
Contributor Author

EthnTuttle commented Sep 25, 2023

fedimint-client/src/lib.rs

Line1515

        Some((_, config)) => {
            // TODO: Enable after <https://github.com/fedimint/fedimint/pull/2855>
            // assert!(
            //     config_source.is_none(),
            //     "Alternative config source provided but config was found in DB"
            // );
            Ok(config)
        }

@justinmoon
Copy link
Contributor

In particular, this file is saved to disk during the devimint setup process. But now that configs are stored in the DB when joining a federation, fedimint-cli we no longer needs or uses this file so I think it would be OK to just stop saving it to disk.

@elsirion
Copy link
Contributor

@maan2003 should this be closed?

@maan2003
Copy link
Member

i found a reference

let cfg_path = self.vars[&0].FM_DATA_DIR.join("client.json");

@bprice6 bprice6 closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants