-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an exception for an index file inside the App layer #55
Comments
Why not |
@illright 1. How do the users usually name their entry point file?I reviewed examples from FSD examples page to see what people usually use. The results are:
So, the users tend to have index files there. 2. Unnecessary limitationI understand that an architectural approach for software is partially about well-thought restrictions that you create for yourself that help you structure things. But I personally believe that restrictions should be applied where they are critical, and should not create additional headaches where they are absolutely unnecessary. 3. Resistance to integrationWhen you see an error from your linter, it takes time to understand what is wrong and why. Then you need to decide what to do. In the case we’re discussing, it can be renaming the file or disabling the rule. This project is still in its early stages so far and I think it is worth reducing resistance to integration as much as possible and the number of such small headaches to a minimum to grow the user base quicker. The more such small things that can annoy users the more chance that another such a small thing can be the last straw where a user decides to abandon/disable the tool. If this still doesn't sound convincing, feel free to close the issue. |
No, these are good points. Besides, this is not the first time we make exceptions for the App layer. I'm convinced, we can add this exception. Feel free to make another PR :) |
Got it, sure, I'll add logic to handle this exception and make a PR soon 👌 |
Right now it reports an error on such a case. But it looks like it should not, because the app layer is the entry point to your application, and it's pretty intuitive that it could have an index.js/ts file.
The text was updated successfully, but these errors were encountered: