Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Commit

Permalink
Merge pull request #625 from fbelavenuto/MOVBE
Browse files Browse the repository at this point in the history
Changed CPU flag FMA to MOVBE (THanks for Peter Suh)
  • Loading branch information
fbelavenuto authored Feb 23, 2023
2 parents 9405793 + ae539cf commit 57ee207
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ There is no need to configure the VID/PID (if using a USB stick) or define the M

If a model is chosen that uses the Device-tree system to define the HDs, there is no need to configure anything. In the case of models that do not use device-tree, the configurations must be done manually and for this there is an option in the "cmdline" menu to display the SATA controllers, DUMMY ports and ports in use, to assist in the creation of the "SataPortMap", "DiskIdxMap" and "sata_remap" if necessary.

Another important point is that the loader detects whether or not the CPU has the FMA3 instruction and does not display the models that require it. So if the DS918+ and DVA3221 models are not displayed it is because of the CPU"s lack of support for FMA instructions. You can disable this restriction and test at your own risk.
Another important point is that the loader detects whether or not the CPU has the MOVBE instruction and does not display the models that require it. So if the DS918+ and DVA3221 models are not displayed it is because of the CPU"s lack of support for MOVBE instructions. You can disable this restriction and test at your own risk.

I developed a simple patch to no longer display the DUMMY port error on models without device-tree, the user will be able to install without having to worry about it.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ serial:
suffix: "numeric"
disks: 4
flags:
- "fma"
- "movbe"
builds:
42218:
ver: "7.0.1"
Expand Down
5 changes: 2 additions & 3 deletions files/board/arpl/overlayfs/opt/arpl/model-configs/DVA3219.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@ synoinfo: &synoinfo
support_memory_compatibility: "no"
esataportcfg: "0x00"
support_bde_internal_10g: "no"
supportraidgroup: "no"
support_syno_hybrid_raid: "yes"
support_led_brightness_adjustment: "no"
rss_server: "https://raw.githubusercontent.com/fbelavenuto/arpl/main/rss.xml"
rss_server_ssl: "https://raw.githubusercontent.com/fbelavenuto/arpl/main/rss.xml"
rss_server_v2: "https://raw.githubusercontent.com/fbelavenuto/arpl/main/rss.json"
support_syno_hybrid_raid:
supportraidgroup:
supportnvme: "yes"
cmdline: &cmdline
syno_hdd_powerup_seq: 0
HddHotplug: 0
Expand All @@ -29,7 +28,7 @@ serial:
middle: "RFR"
suffix: "alpha"
flags:
- "fma"
- "movbe"
disks: 4
builds:
42218:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ synoinfo: &synoinfo
rss_server_v2: "https://raw.githubusercontent.com/fbelavenuto/arpl/main/rss.json"
support_syno_hybrid_raid:
supportraidgroup:
supportnvme: "yes"
cmdline: &cmdline
syno_hdd_powerup_seq: 0
HddHotplug: 0
Expand All @@ -28,7 +29,7 @@ serial:
middle: "SJR"
suffix: "alpha"
flags:
- "fma"
- "movbe"
disks: 4
builds:
42218:
Expand Down

0 comments on commit 57ee207

Please sign in to comment.