Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian translation #1748

Closed
shidenko97 opened this issue Jul 20, 2020 · 17 comments
Closed

Ukrainian translation #1748

shidenko97 opened this issue Jul 20, 2020 · 17 comments
Labels
feature New feature or request lang-all Translations lang-uk Ukrainian translations

Comments

@shidenko97
Copy link

Ukrainian translation (/uk)

I"ve been starting to translate docs to Ukrainian language. I will be happy everyone helpers)

@ArcLightSlavik
Copy link
Contributor

I can look at this on the weekend

But for now we should use "UA" as the country code in line with: https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

@shidenko97
Copy link
Author

I can look at this on the weekend

But for now we should use "UA" as the country code in line with: https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

To be honest can"t agree with you - we talk about language code, not about country code. For example Japan has a jp country code, but Japanese language has a ja code. And Ukraine as a country has a ua code, but Ukrainian language has a uk code.

@ArcLightSlavik
Copy link
Contributor

Ah true
Though it was the same 🙈

@Kludex
Copy link
Member

Kludex commented Jul 21, 2020

@shidenko97
Copy link
Author

I can look at this on the weekend

Will try to finish translation of index page till weekends and will be happy your review)

@ArcLightSlavik
Copy link
Contributor

@shidenko97 gentle ping for review:upside_down_face:

@shidenko97
Copy link
Author

@shidenko97 gentle ping for review🙃

Re-check it for typos, please (In first 30 lines I"ve found 3)
I will try to finish my version today and we can combine it in one perfect version

@ArcLightSlavik
Copy link
Contributor

I"ve closed #1790 in favour of #1791

@shidenko97 i think it"s better to review this way: #1363 (review)
I don"t have that much time to go through it again and try to spot issues

I"ll try review #1791 this week but no promises:pensive:

@mezgoodle
Copy link
Contributor

How can I contribute the translation? What is the right way?

@ArcLightSlavik
Copy link
Contributor

@mezgoodle Considering creator of #1791 is gone, you can take his pull request and remake it (taking in the reviews from that pull request) and I"ll review it. My review might be enough to merge it.

@mezgoodle
Copy link
Contributor

@mezgoodle Considering creator of #1791 is gone, you can take his pull request and remake it (taking in the reviews from that pull request) and I"ll review it. My review might be enough to merge it.

Do I need to create my own pull request?

@ArcLightSlavik
Copy link
Contributor

@mezgoodle Yes, just create a new one.

@github-actions
Copy link
Contributor

Good news everyone! 😉 There"s a new translation PR to be reviewed: #4037 🎉

@github-actions
Copy link
Contributor

Good news everyone! 😉 There"s a new translation PR to be reviewed: #4569 🎉

@github-actions
Copy link
Contributor

Good news everyone! 😉 There"s a new translation PR to be reviewed: #4570 🎉

@github-actions
Copy link
Contributor

Good news everyone! 😉 There"s a new translation PR to be reviewed: #4572 🎉

@github-actions
Copy link
Contributor

Good news everyone! 😉 There"s a new translation PR to be reviewed: #4574 🎉

@tiangolo tiangolo added lang-all Translations lang-uk Ukrainian translations labels Oct 19, 2022
@tiangolo tiangolo changed the title [FEATURE] Ukrainian translation Ukrainian translation Feb 24, 2023
@tiangolo tiangolo removed the reviewed label Mar 4, 2023
@fastapi fastapi locked and limited conversation to collaborators Mar 4, 2023
@tiangolo tiangolo converted this issue into discussion #9192 Mar 4, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature New feature or request lang-all Translations lang-uk Ukrainian translations
Projects
None yet
Development

No branches or pull requests

5 participants