Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass decompressed state to onBeforeRead #1634

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Pass decompressed state to onBeforeRead #1634

merged 1 commit into from
Aug 13, 2024

Conversation

ypc-faros
Copy link
Contributor

@ypc-faros ypc-faros commented Aug 13, 2024

Description

Noticed that my previous PR , which uses the state, was not working. We're passing the possibly compressed state to the onBeforeRead function, so that's why this wouldn't work.

Type of change

  • Bug fix
  • New feature
  • Breaking change

Related issues

Fix #1

Migration notes

Describe migration notes if any

Extra info

Add any additional information

Copy link

sonarcloud bot commented Aug 13, 2024

Copy link
Contributor

@matiaslcoulougian matiaslcoulougian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ypc-faros ypc-faros merged commit becc7af into main Aug 13, 2024
7 checks passed
@ypc-faros ypc-faros deleted the ypc/state branch August 13, 2024 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants