Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response headers are gone when exception is raised in controller #17

Closed
zamronypj opened this issue Apr 17, 2021 · 1 comment
Closed

Response headers are gone when exception is raised in controller #17

zamronypj opened this issue Apr 17, 2021 · 1 comment
Assignees
@zamronypj
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@zamronypj
Copy link
Member

zamronypj commented Apr 17, 2021 •
edited
Loading

When you put response headers in middleware and in controller you raise exception. Response headers previously set are gone. Exception handling should keep response headers.
@zamronypj zamronypj added the bug Something isn't working label Apr 17, 2021
@zamronypj zamronypj self-assigned this Apr 17, 2021
@zamronypj zamronypj added the help wanted Extra attention is needed label Apr 17, 2021
@zamronypj
Copy link
Member Author

Fixed in eaf8376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zamronypj zamronypj

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zamronypj