-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude exe_running_docker_save in the "Modify Shell Configuration File" rule #949
Exclude exe_running_docker_save in the "Modify Shell Configuration File" rule #949
Conversation
@JPLachance what is your docker info? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT this too! Thanks @JPLachance
Can you modify the commit message please? :)
…le" rule Signed-off-by: Jean-Philippe Lachance <[email protected]>
Signed-off-by: Jean-Philippe Lachance <[email protected]>
LGTM label has been added. Git tree hash: 1931c5b16c0cde94c4da71e9ef1245fbfa9c6e6c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.19.0 |
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
The "Modify Shell Configuration File" gets fired each time we launch a container.
This event is surrounded by dozens like it.
Adding a simple
and not exe_running_docker_save
fixes the issue.Which issue(s) this PR fixes:
I did not file an issue, here is the PR instead!
Special notes for your reviewer:
Does this PR introduce a user-facing change?: