Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude exe_running_docker_save in the "Modify Shell Configuration File" rule #949

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Exclude exe_running_docker_save in the "Modify Shell Configuration File" rule #949

merged 2 commits into from
Dec 4, 2019

Conversation

JPLachance
Copy link
Contributor

@JPLachance JPLachance commented Dec 3, 2019

What type of PR is this?
/kind bug
/kind rule-update

Any specific area of the project related to this PR?
/area rules

What this PR does / why we need it:
The "Modify Shell Configuration File" gets fired each time we launch a container.

{
    "output_fields": {
      "container.id": "host",
      "proc.cmdline": "exe /var/lib/docker/aufs/diff/2af477a6cb2dc69462ddd8aa43a147dab7cd86f7580d1766b2043143eb267d07",
      "evt.time": 1575046614282228200,
      "fd.name": "/etc/profile",
      "user.name": "root"
    },
    "output": "16:56:54.282228311: Warning a shell configuration file has been modified (user=root command=exe /var/lib/docker/aufs/diff/2af477a6cb2dc69462ddd8aa43a147dab7cd86f7580d1766b2043143eb267d07 file=/etc/profile container_id=host image=<NA>)",
    "rule": "Modify Shell Configuration File",
    "priority": "Warning"
  }

This event is surrounded by dozens like it.

Adding a simple and not exe_running_docker_save fixes the issue.

Which issue(s) this PR fixes:
I did not file an issue, here is the PR instead!

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules(Modify Shell Configuration File): fixed a false positive by excluding "exe_running_docker_save"

@Kaizhe
Copy link
Contributor

Kaizhe commented Dec 3, 2019

@JPLachance what is your docker info?

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT this too! Thanks @JPLachance

Can you modify the commit message please? :)

rules/falco_rules.yaml Outdated Show resolved Hide resolved
@poiana
Copy link
Contributor

poiana commented Dec 3, 2019

LGTM label has been added.

Git tree hash: 1931c5b16c0cde94c4da71e9ef1245fbfa9c6e6c

@poiana
Copy link
Contributor

poiana commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido leodido merged commit df7a356 into falcosecurity:dev Dec 4, 2019
@leodido
Copy link
Member

leodido commented Dec 4, 2019

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Dec 4, 2019
@JPLachance JPLachance deleted the fix-exe-docker-save-modify-shell-conf branch February 4, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants